Optional settings in Shoes::App #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, I think this isn't a great idea. It's a new Shoes3 incompatibility. There's basically always a way to do the same thing another way (e.g. env vars, or attributes on HTML elements for SpaceShoes.) And the setting values are purely Scarpe-impl-dependent, so it's kind of a liability to even include them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add settings for Shoes::App which will be ignored by the Lacci side.
A Shoes application can be specific to a particular Shoes implementation, and can have settings that are specific to that implementation. A gtk-scarpe application might want to specify a particular GTK+ theme. A scarpe-wasm app might specify how much local storage it wants reserved on its behalf. A SpaceShoes app might want to specify the Ruby version for ruby.wasm or the div to use for displaying output.
For that, we want Lacci to permit (optional) settings that will be passed through to the Scarpe implementation.
Like "features" (a list of symbols and symbol-lists which cannot contain significant data), this is an optional extension to Shoes. Shoes3 did not have this parameter.
Possible future work: should this parameter be gated behind the :scarpe feature?
Checklist